Skip to content

fix(dialog): fire afterClosed callback after all dialog actions are done #3892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2017
Merged

fix(dialog): fire afterClosed callback after all dialog actions are done #3892

merged 1 commit into from
Apr 17, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 4, 2017 •
edited
Loading

  • Fires the afterClosed callback once the dialog is removed and the previously-focused element has been refocused. Until now the order was reversed, which prevents people from being able to refocus a different element.
  • Cleans up the MdDialogContainer logic to simplify it and to remove the need to subscribe to zone events.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 4, 2017
@crisbeto crisbeto changed the title fix(dialog): fire afterClosed callback after animation is done fix(dialog): fire afterClosed callback after all dialog actions are done Apr 4, 2017
@crisbeto crisbeto force-pushed the 3890/dialog-afterclosed-order branch from d7f05de to 0c3d90e Compare April 4, 2017 13:33
@crisbeto crisbeto force-pushed the 3890/dialog-afterclosed-order branch 2 times, most recently from 16530c7 to 9d883ff Compare April 4, 2017 19:38
@crisbeto crisbeto force-pushed the 3890/dialog-afterclosed-order branch 2 times, most recently from e394ff1 to ec7930a Compare April 4, 2017 22:25
@crisbeto
fix(dialog): fire afterClosed callback after all dialog actions are done
0809250 
* Fires the afterClosed callback once the dialog is removed and the previously-focused element has been refocused. Until now the order was reversed, which prevents people from being able to refocus a different element.
* Cleaned up the `MdDialogContainer` logic to simplify it and to remove the need to subscribe to zone events.
@crisbeto crisbeto force-pushed the 3890/dialog-afterclosed-order branch from ec7930a to 0809250 Compare April 5, 2017 03:49
jelbourn
jelbourn approved these changes Apr 14, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Apr 14, 2017
@jelbourn jelbourn merged commit ee1a5a7 into angular:master Apr 17, 2017
@willshowell willshowell mentioned this pull request Apr 26, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @googlebot